Skip to content

UtBotFieldModificatorsSearcher fixed for default package and public fields #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

EgorkaKulikov
Copy link
Collaborator

Description

Searcher of field modificators fixed for default package: in the previous implementation it considered all modificators appropriate if they are located in a default package.
Also public fields validation corrected.

Fixes # (1024)

Type of Change

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Automated Testing

UtBotFieldModificatorsTest

Manual Scenario

Repeat the scenario described in the mentioned feature with fuzzer and concrete executor turned off.

Copy link
Collaborator

@volivan239 volivan239 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK as a temporary hack, please, add a comment with TODO about it.

@EgorkaKulikov EgorkaKulikov marked this pull request as draft September 30, 2022 16:34
@EgorkaKulikov
Copy link
Collaborator Author

Replaced with a nornal fix, not like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants