Fixed unavailable mock classes #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damtev
force-pushed
the
damtev/static_mocks_fix
branch
3 times, most recently
from
29e726f to
11820f0
Compare
EgorkaKulikov
approved these changes
Oct 4, 2022
Damtev
force-pushed
the
damtev/static_mocks_fix
branch
from
11820f0 to
4c29331
Compare
sergeypospelov
approved these changes
Oct 5, 2022
denis-fokin
pushed a commit
that referenced
this pull request
Oct 5, 2022
(cherry picked from commit 1260c8f)
AbdullinAM
pushed a commit
to AbdullinAM/UTBotJava
that referenced
this pull request
Oct 17, 2022
AbdullinAM
pushed a commit
to AbdullinAM/UTBotJava
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After introducing nullability and single type parameter for Kotlin code generation, static mocks became broken - they were no longer considered as
BuiltinClassId, which means they were tried to load with default class loader which is impossible due to classes from mock frameworks could not be load with it.This request makes mock classes builtin again - it fixes the problem but is incorrect for Kotlin code generation. The proper support of it should be designed and implemented together with generics in code generation (as planned in #88).
Fixes #981.
Type of Change
Breaking change (fix or feature that would cause existing functionality to not work as expected)
How Has This Been Tested?
Manual Scenario
Generating tests as mentioned in the issue.
Checklist: