Select Kotlin test src root by default when generating for Kotlin #949 #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volivan239
force-pushed
the
volivan239/change_default_test_source_root_for_kotlin
branch
from
8d69150 to
49bf74b
Compare
| val testRoots = with (testRootsByLanguage.entries) { | ||
| filter { it.key == model.codegenLanguage } + filter { it.key != model.codegenLanguage } | ||
| }.flatMap { it.value }.toMutableList() | ||
|
|
There was a problem hiding this comment.
Please use sorting instead of filtering
volivan239
force-pushed
the
volivan239/change_default_test_source_root_for_kotlin
branch
from
49bf74b to
7c6ab37
Compare
Vassiliy-Kudryashov
approved these changes
Oct 10, 2022
volivan239
deleted the
volivan239/change_default_test_source_root_for_kotlin
branch
viktoriia-fomina
pushed a commit
that referenced
this pull request
Oct 12, 2022
AbdullinAM
pushed a commit
to AbdullinAM/UTBotJava
that referenced
this pull request
Oct 17, 2022
AbdullinAM
pushed a commit
to AbdullinAM/UTBotJava
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now, if project has both Java and Kotlin tests source roots, UTBot by default selects one that matches code generation language.
Note that currently there is no proper way to check whether source root is for Java or for Kotlin, so we mainly decide this by folder name (see
org.utbot.intellij.plugin.ui.utils.ModuleUtilsKt#getExpectedLanguageForTestsand comment there).Fixes #949
Type of Change
How Has This Been Tested?
Manual Scenario
Repeated scenario from #949 -- works as expected.
Checklist (remove irrelevant options):
This is the author self-check list