Improve verification that static mocking is configured #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorkaKulikov
force-pushed
the
egor/static_mocks_file_search
branch
from
6444031 to
825b853
Compare
EgorkaKulikov
force-pushed
the
egor/static_mocks_file_search
branch
from
9090cd7 to
e358e0a
Compare
mmvpm
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation of searching that static mocking is configured has a problem that we firstly obtain all file names from the content entry and only after that verify that a required name is present. It will lead us to problems if there are millions of files in the content entry.
Implementation was improved in accordance with lazy practices.
Type of Change
How Has This Been Tested?
Manual Scenario
Verify that we do not create tests with static mocking if there is no special file in any of test source root resource folders.