Get PsiClass' package by declaration in containingFile and not by its directory #1081 #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volivan239
force-pushed
the
volivan239/fix_classnotfound_wrong_package
branch
from
99f38a1 to
5569063
Compare
Vassiliy-Kudryashov
approved these changes
Oct 7, 2022
AbdullinAM
pushed a commit
to AbdullinAM/UTBotJava
that referenced
this pull request
Oct 17, 2022
AbdullinAM
pushed a commit
to AbdullinAM/UTBotJava
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If package in which class was put doesn't match its directory, we should use
packageNameof containingPsiFileaspackageNamefor class (and not the directory of containing file).Fixes #1081
Type of Change
Manual Scenario
Checked on scenario from #1081 (both when we launch action on misplaced class and when we launch action on method in other class where misplaced class is used) -- tests are generated correctly (although, IDEA can't always correctly handle wrong package).
Checklist (remove irrelevant options):