Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static mocking #1142

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Fix static mocking #1142

merged 1 commit into from
Oct 12, 2022

Conversation

SBOne-Kenobi
Copy link
Collaborator

@SBOne-Kenobi SBOne-Kenobi commented Oct 12, 2022

Description

Mocking in concrete executor respected only method signature without any information about declaring class. Therefore, when we wanted to mock two methods with the same signatures but in different classes, we ignored mocking one of them.
Now, new signature of method includes fully qualified name of declaring class.

Fixes #1128

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Scenario

Described in issue #1128

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@SBOne-Kenobi SBOne-Kenobi force-pushed the sbone/fix-static-mocking branch from 86bf0cd to d0497a9 Compare October 12, 2022 05:55
@SBOne-Kenobi SBOne-Kenobi requested a review from mmvpm October 12, 2022 06:31
@SBOne-Kenobi SBOne-Kenobi enabled auto-merge (squash) October 12, 2022 06:39
@SBOne-Kenobi SBOne-Kenobi merged commit 5af1f48 into main Oct 12, 2022
@SBOne-Kenobi SBOne-Kenobi deleted the sbone/fix-static-mocking branch October 12, 2022 07:09
denis-fokin pushed a commit that referenced this pull request Oct 12, 2022
(cherry picked from commit 5af1f48)
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad static method mocking
2 participants