Skip to content

Remove name field from BuiltinClassId #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Conversation

EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented Oct 20, 2022

Description

BuiltinClassId should avoid setting name field because it is always similar to canonicalName for it.
Setting it directly incorrectly lead to some problems.

Type of Change

  • Refactoring (typos and non-functional changes)

How Has This Been Tested?

Automated Testing

Standard utbot pipeline

@EgorkaKulikov EgorkaKulikov marked this pull request as draft October 20, 2022 12:49
@EgorkaKulikov EgorkaKulikov marked this pull request as ready for review October 20, 2022 12:56
@EgorkaKulikov EgorkaKulikov marked this pull request as draft October 20, 2022 13:29
@EgorkaKulikov EgorkaKulikov marked this pull request as ready for review October 20, 2022 19:44
@EgorkaKulikov EgorkaKulikov removed the request for review from volivan239 October 21, 2022 06:54
@EgorkaKulikov EgorkaKulikov merged commit 80a962b into main Oct 21, 2022
@EgorkaKulikov EgorkaKulikov deleted the egor/name_builtins branch October 21, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants