Map doesn't work without concrete #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damtev
approved these changes
Oct 25, 2022
utbot-framework/src/main/kotlin/org/utbot/engine/ArrayObjectWrappers.kt
Outdated
Show resolved
Hide resolved
CaelmBleidd
force-pushed
the
caelmbleidd/map_fixes
branch
from
a1e577e to
268b0c3
Compare
Fixes: * aliasing between nested arrays of UtHashMap and its fields * unsat for get operation from Map
CaelmBleidd
force-pushed
the
caelmbleidd/map_fixes
branch
3 times, most recently
from
a648d4e to
410c58d
Compare
sergeypospelov
approved these changes
Oct 26, 2022
CaelmBleidd
force-pushed
the
caelmbleidd/map_fixes
branch
from
827f0d4 to
43d1dd3
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/map_fixes
branch
from
43d1dd3 to
03ffb84
Compare
alisevych
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At some moment we discovered that maps do not work as they suppose: sometimes concrete could fix it (for example, when a map was not a parameter), sometimes could not. This request fixes two particular problems: error in type indices for
selectoperation and possible aliasing between nested arrays.A problem with aliasing could be seen while debugging org.utbot.examples.collections.Maps#putInMapFromParameters. Without this fix it doesn't work for an empty map:
touchedandvaluesmight have the same address, and if we make twoputoperations, the second one will cause a problem -- memory update for keys will rewrite values as well, and we'll have wrong result values. With one put or with a map that was created during the execution everything worked fine (after the fix with types)Fixes #436
Type of Change
How Has This Been Tested?
Automated Testing
org.utbot.examples.collections.Maps#createMapWithEnum
org.utbot.examples.collections.Maps#createMapWithString
org.utbot.examples.collections.Maps#containsKeyAndPuts
org.utbot.examples.collections.Maps#putInMapFromParameters
org.utbot.examples.collections.Maps#mapPutAndGet
Manual Scenario
Didn't check manually.
Checklist: