-
Notifications
You must be signed in to change notification settings - Fork 47
Add a common Simplificator
in the Traverser
#1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
331f8e2
to
6a964f8
Compare
6a964f8
to
8fdcacc
Compare
Simplificator
in the Traverser
CaelmBleidd
requested changes
Nov 2, 2022
utbot-framework/src/main/kotlin/org/utbot/engine/simplificators/MemoryUpdateSimplificator.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/simplificators/MemoryUpdateSimplificator.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/simplificators/MemoryUpdateSimplificator.kt
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/simplificators/MemoryUpdateSimplificator.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/state/ExecutionStackElement.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/state/ExecutionStackElement.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/state/ExecutionStackElement.kt
Outdated
Show resolved
Hide resolved
CaelmBleidd
approved these changes
Nov 2, 2022
7d1b630
to
3c85ca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor:
runBlockingWithCancellationPredicate
in our tests pipelineExecutionState
toorg.utbot.engine.state
package. Moved out succeeding operations forExecutionState
toExecutionStateUpdates.kt
Add:
Simplifer
which holds a cache for a wholeTraverser
.MemoryUpdateSimplifier
which simplifiesMemoryUpdate
s.Problems:
SetsTest::testSetContainsInteger
was continuously failing. Now they aren't being simplified explicitly, but simplified implicitly withTraverser::resolve(Value)
function.Type of Change
How Has This Been Tested?
Automated Testing
Tests are passing.
Manual Scenario
I checked our engine on synthetic test with ~200 groups of array store and array select expressions (see code), and now it's 50 times faster.
Checklist: