Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solver optimizations #1265

Merged
merged 4 commits into from
Nov 1, 2022
Merged

Solver optimizations #1265

merged 4 commits into from
Nov 1, 2022

Conversation

CaelmBleidd
Copy link
Member

@CaelmBleidd CaelmBleidd commented Oct 31, 2022 •
edited
Loading

Description

This request improves performance of the engine by removing some constraints from the queries to a solver.

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Automated Testing

The whole pipeline is working fine, runs using contestEstimator didn't find any new issues

Manual Scenario

It was not tested manually.

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@CaelmBleidd CaelmBleidd force-pushed the caelmbleidd/optimizations branch from 5e3103c to 679573d Compare October 31, 2022 10:29
@CaelmBleidd CaelmBleidd force-pushed the caelmbleidd/optimizations branch from 679573d to 9a08b82 Compare October 31, 2022 11:44
Damtev
Damtev approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

utbot-framework/src/main/kotlin/org/utbot/engine/Resolver.kt Show resolved Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/pc/Z3TranslatorVisitor.kt Outdated Show resolved Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/pc/Z3TranslatorVisitor.kt Outdated Show resolved Hide resolved
@CaelmBleidd CaelmBleidd merged commit 1115aad into main Nov 1, 2022
@CaelmBleidd CaelmBleidd deleted the caelmbleidd/optimizations branch November 1, 2022 07:00
@alisevych alisevych mentioned this pull request Nov 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damtev Damtev Damtev approved these changes

@sergeypospelov sergeypospelov sergeypospelov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaelmBleidd @sergeypospelov @Damtev