Skip to content

Summaries should be turned off for Kotlin related generations #1283 #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2022
Merged

Summaries should be turned off for Kotlin related generations #1283 #1298

merged 3 commits into from
Nov 3, 2022

Conversation

Vassiliy-Kudryashov
Copy link
Member

Description

Allow summaries generation for Java only:

  1. Dependency in UI added
  2. Patch for Settings.State loading added to prevent inconsistency in case of existing config where language is Kotlin and at the same time summary enabled

Fixes #1283

Type of Change

  • Enhancement

How Has This Been Tested?

Manual Scenario

  1. Go to settings, select Kotlin.
  2. 'Enable Summaries Generation' checkbox should become disabled and unchecked
  3. OK->Close settings [optionally restart IDE] and open settings again: Kotlin is selected, checkbox is still disabled and unchecked
  4. Select Java. The checkbox becomes enabled in unchecked state.
  5. OK->Reopen settings, the checkbox dosen't lose its state. Check it.
  6. OK->Reopen settings, the checkbox is enabled and now it's checked.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings

@Vassiliy-Kudryashov Vassiliy-Kudryashov linked an issue Nov 2, 2022 that may be closed by this pull request
Summaries should be turned off for Kotlin related generations #1283
Closed
amandelpie
amandelpie approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@amandelpie amandelpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably 2-3 TODOs could be added to fix in the nearest future

@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) November 3, 2022 10:36
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 8734d59 into main Nov 3, 2022
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/1283-summaries-should-be-turned-off-for-kotlin-related-generations branch November 3, 2022 10:56
denis-fokin pushed a commit that referenced this pull request Nov 7, 2022
@Vassiliy-Kudryashov @denis-fokin
Summaries should be turned off for Kotlin related generations #1283 (#…
23afe65 
…1298)

(cherry picked from commit 8734d59)
@alisevych alisevych mentioned this pull request Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandelpie amandelpie amandelpie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Summaries should be turned off for Kotlin related generations
2 participants
@Vassiliy-Kudryashov @amandelpie