Skip to content

Add sandbox failures to SARIF report (#1276) #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

mmvpm
Copy link
Collaborator

@mmvpm mmvpm commented Nov 14, 2022

Description

Added executions with UtSandboxFailure to the SARIF report to display them on the Problems tab.

Fixes #1276, #1168

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Automated Testing

org.utbot.sarif.SarifReportTest

Manual Scenario

  1. Enable the checkbox "Display detected errors..." in the project settings

  2. Run test generation on

     public class Example {
         public String property(String key) {
             return System.getProperty(key);
         }
     }
  3. Check the detected error:

    image

    image

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@mmvpm mmvpm self-assigned this Nov 14, 2022
@mmvpm mmvpm requested a review from SBOne-Kenobi November 14, 2022 08:57
@mmvpm mmvpm linked an issue Nov 14, 2022 that may be closed by this pull request
@alisevych
Copy link
Member

Please check test generation for InnerCalls.doubleCallFactorial()
There is an error test with StackOverflowError generated for it:

  • there is almost empty stacktrace for it

image

  • the wrong line is addressed in code:

image

@alisevych
Copy link
Member

There are 1024 lines in stack traces for Recursion:

  • for example Recursion.fib(), .factorial(), .sum(), ...
    Is it Ok?

@mmvpm mmvpm merged commit 21e502b into main Nov 16, 2022
@mmvpm mmvpm deleted the ideaseeker/sandbox_failure_in_sarif branch November 16, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Sandboxed tests on Problems tab Show risky disabled tests as Problems and in SARIF-report
3 participants