Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If invalid value is set for a property in settings.properties, defaul… #1464

Conversation

Vassiliy-Kudryashov
Copy link
Member

…t value should be applied #1437

Description

Standard Boolean.parseBoolean() returns false for all invalid values, new parser will return defaultValue instead.

Fixes #1437

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Regression and integration tests

org.utbot.common.AbstractSettingsTest

Manual Scenario

See the issue

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

…-set-for-a-property-in-settingsproperties-default-value-should-be-applied
@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) December 6, 2022 14:34
…-set-for-a-property-in-settingsproperties-default-value-should-be-applied
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit e379980 into main Dec 6, 2022
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/1437-if-invalid-value-is-set-for-a-property-in-settingsproperties-default-value-should-be-applied branch December 6, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If invalid value is set for a property in settings.properties, default value should be applied
2 participants