Remove access for jClass in UtMockFieldInfo #1525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use information from
jClass
when Mocker decides whether it should mock some object or not. Because of many reasons, these classes might be unavailable in Runtime and we have to work with it usingSootClass
instances.This problem was found during work on closed project and I don't have a way to reproduce it, but it is a problem that happen many times in the past and we should avoid accessing
jClass
whenever possible.Type of Change
How Has This Been Tested?
Regression and integration tests
There are no additional tests since they highly depend on classpath, project configuration, soot transformation and other options. Unfortunately, the exact combination of these options is lost and the problem occurred on a project with closed code.
Automated Testing
There are no additional automatic tests.
Manual Scenario
There are no manual scenarios.
Checklist (remove irrelevant options):
This is the author self-check list