Removed redundant switch-case in mocks in case of only one branch #1954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damtev
added
comp-codegen
Damtev
force-pushed
the
damtev/mock_redundant_switch
branch
from
b5df285 to
1d889c4
Compare
...ework/src/main/kotlin/org/utbot/framework/codegen/services/framework/MockFrameworkManager.kt
Outdated
Show resolved
Hide resolved
Damtev
force-pushed
the
damtev/mock_redundant_switch
branch
from
1d889c4 to
fb6b3bc
Compare
...ework/src/main/kotlin/org/utbot/framework/codegen/services/framework/MockFrameworkManager.kt
Outdated
Show resolved
Hide resolved
...ework/src/main/kotlin/org/utbot/framework/codegen/services/framework/MockFrameworkManager.kt
Outdated
Show resolved
Hide resolved
EgorkaKulikov
approved these changes
Mar 15, 2023
denis-fokin
pushed a commit
that referenced
this pull request
Mar 16, 2023
) (cherry picked from commit 7230073)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we have only one branch in mocking new instances - i.e., we consider only the first invocation of executables - we do not need a switch-case and corresponding counter for labels.
Fixes #1878.
How to test
Automated tests
Common pipeline.
Manual tests
Mentioned in the corresponding issue.
Self-check list