Provide references to invoked methods in summary #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onewhl
added
the
comp-summaries
amandelpie
reviewed
Jul 18, 2022
| */ | ||
| protected fun invokeDescription(className: String, methodName: String) = "$className::$methodName" //TODO SAT-1311 | ||
| protected fun invokeDescription(className: String, methodName: String, methodParameterTypes: List<Type>): String { |
There was a problem hiding this comment.
I have a simple note for the future (let's cover this functionality with the unit tests located in the summary module itself)
I'm going to merge first test with DBSCAN #345 issue and you could create a ticket to cover it with the unit functionality without test generation from scratch.
I suggest to cover all known builders, it will be easier to see if something broken there. Also you could use UTBot or Fuzzer to generate these unit tests @onewhl
There was a problem hiding this comment.
Sounds awesome, I've created a separate ticket for it: #543
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide references to invoked methods in summary to make it possible to navigate to them by click.
Fixes #462
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Automated Testing
I fixed the tests affected by the change and added them to this PR.
Manual Scenario
I ran the plugin on several code snippets to make sure that the links the plugin shows are correct.
Checklist (remove irrelevant options):