Skip to content

Disabled tests for autogenerated functions #457 #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

volivan239
Copy link
Collaborator

@volivan239 volivan239 commented Jul 12, 2022

Description

Disabled tests for autogenerated methods (values, valueOf) for enum classes.
Fixes #457

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Automated Testing

No new tests currently added (in progress)

Manual Scenario

  • Launch plugin on empty enum class -- it will suppose no methods to generate test, as expected
  • Launch contest estimator on com.google.common.base.CaseFormat.* -- it will no more generate tests for values and valueOf.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • Tests that prove my change is effective
  • All tests pass locally with my changes

@volivan239 volivan239 requested a review from dtim July 12, 2022 15:29
Copy link
Collaborator

@dtim dtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments.

@volivan239 volivan239 changed the title Disabled tests for autogenerated functions Disabled tests for autogenerated functions #457 Jul 15, 2022
@volivan239 volivan239 requested a review from dtim July 15, 2022 08:24
@volivan239 volivan239 marked this pull request as ready for review July 15, 2022 08:25
Copy link
Collaborator

@dtim dtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algorithmically and conceptually the PR is good, but there are some issues with the code organization. I would like also suggest some stylistic changes.

volivan239 pushed a commit that referenced this pull request Jul 18, 2022
@volivan239 volivan239 requested a review from dtim July 18, 2022 12:05
@volivan239 volivan239 force-pushed the volivan239/disable-tests-for-autogenerated branch from dc010f6 to a245bc6 Compare July 18, 2022 12:59
Copy link
Collaborator

@dtim dtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If possible, it would be nice to have some unit tests in CLI.

@volivan239 volivan239 merged commit ff1ea73 into main Jul 18, 2022
@volivan239 volivan239 deleted the volivan239/disable-tests-for-autogenerated branch July 18, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Unexpected tests for some inherited methods on enums
2 participants