-
Notifications
You must be signed in to change notification settings - Fork 47
Disabled tests for autogenerated functions #457 #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments.
utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/GenerateTestsDialogWindow.kt
Outdated
Show resolved
Hide resolved
utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/UtTestsDialogProcessor.kt
Outdated
Show resolved
Hide resolved
utbot-junit-contest/src/main/kotlin/org/utbot/contest/Contest.kt
Outdated
Show resolved
Hide resolved
utbot-cli/src/main/kotlin/org/utbot/cli/GenerateTestsCommand.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Algorithmically and conceptually the PR is good, but there are some issues with the code organization. I would like also suggest some stylistic changes.
utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/util/SyntethicMethodsChecker.kt
Outdated
Show resolved
Hide resolved
utbot-framework-api/src/main/kotlin/org/utbot/framework/SyntheticMethods.kt
Outdated
Show resolved
Hide resolved
utbot-framework-api/src/main/kotlin/org/utbot/framework/SyntheticMethods.kt
Outdated
Show resolved
Hide resolved
utbot-junit-contest/src/main/kotlin/org/utbot/contest/Contest.kt
Outdated
Show resolved
Hide resolved
dc010f6
to
a245bc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If possible, it would be nice to have some unit tests in CLI.
Description
Disabled tests for autogenerated methods (values, valueOf) for enum classes.
Fixes #457
Type of Change
How Has This Been Tested?
Automated Testing
No new tests currently added (in progress)
Manual Scenario
com.google.common.base.CaseFormat.*
-- it will no more generate tests forvalues
andvalueOf
.Checklist (remove irrelevant options):