Skip to content

Concrete executor rd logs #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Conversation

Domonion
Copy link
Collaborator

@Domonion Domonion commented Sep 9, 2022

Description

  1. fix Log of concrete execution doesn't print exception anymore #870
  2. fix UninitializedPropertyAccessException when transforming in Concrete Execution #848 changed concrete executor process logs: removed kotlin.logs, moved to rd logging system, overloaded them to write to system.err, adjusted log level of some messages to clarify log, removed useless schedulers and some useless code

Also

  1. Removed excessive RD-related logs, moved them to Trace category, current is Info
  2. Exeptions again are shown in log file
  3. Currently concrete executor process supports only programmatical way of settings log level, this will be addresed in future utbot process separation. Use org.utbot.instrumentation.process.ChildProcessKt#logLevel . Change level to Debug to see all executed requests without RD-logs, but they still might heavily pollute logs, but not that hard as Trace level.

N.B.: log system will be redesigned with upcoming utbot test generator process separation! Changes will be reflected on UtBotJava rd wiki page.

Fixes # (issue)
#870
#848

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (typos and non-functional changes)

How Has This Been Tested?

Manual Scenario

See #870 and #848

1. fix #870
2. fix #848
changed concrete executor process logs: removed kotlin.logs, moved to rd
logging system, overloaded them to write to system.err, adjusted log
level of some messages to clarify log, removed useless schedulers and
some useless code

N.B.: log system will be redesigned with upcoming utbot test generator
process separation! Changes will be reflected on UtBotJava rd wiki page.
@Domonion Domonion added this to the Release preparation milestone Sep 9, 2022
@Domonion Domonion requested a review from Markoutte September 9, 2022 15:32
@Domonion Domonion self-assigned this Sep 9, 2022
@Domonion
Copy link
Collaborator Author

Domonion commented Sep 9, 2022

@alisevych

@Domonion Domonion merged commit 39354b1 into main Sep 12, 2022
@Domonion Domonion deleted the kononov-concrete-executor-logs-fix branch September 12, 2022 08:34
@Domonion
Copy link
Collaborator Author

@EgorkaKulikov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Log of concrete execution doesn't print exception anymore UninitializedPropertyAccessException when transforming in Concrete Execution
3 participants