-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ProcessUtil #293
Merged
Merged
Add ProcessUtil #293
+139
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `Util.sh`, but with Kotlin and coroutines
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## neo #293 +/- ##
============================================
+ Coverage 71.31% 71.64% +0.33%
- Complexity 2430 2448 +18
============================================
Files 254 255 +1
Lines 14385 14505 +120
Branches 2106 2126 +20
============================================
+ Hits 10258 10392 +134
+ Misses 3257 3224 -33
- Partials 870 889 +19 ☔ View full report in Codecov by Sentry. |
`inputReader`, `errorReader`, `outputWriter` are only available since Java 17
CaelmBleidd
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the utility function
ProcessUtil.run
similar toUtil.sh
fromjdot
, but better (written in Kotlin and using coroutines).Show the captured output (stdout/stderr) in case of execution failure (exitCode != 0
).ProcessUtil.run
instead of ad-hocrunProcess
.Add unit tests.