Support mutable locations #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[jacodb-core] Minor: reduce number of downloads Two versions of the Keap lib are downloaded twice, not three times. [jacodb-core] Make code model with ERS backend mutable incremental As of this commit, ErsPersistenceImpl has got the following additional features: - For any location and class name, there can exist several entities. - Amongst those entities, only one is active (current), other are logically deleted, i.e. marked with "isDeleted" property. - Any location identified by its id can be forced to be re-indexed. Only changed classes are getting the new version during re-indexing. - For binding Persistence layer with the layer of JcDatabase, a new ClassSource implementation introduced. For getting class' byte code, this implementation checks if class id which it holds is up-to-date. - Code model re-indexes changed locations after JcDatabase.refresh() is invoked. TODO. PersistentLocationsRegistry looks overcomplicated. JcLocation implementations look as hacks in order to get JcLocation.isChanged() working, and in order to reindex mutated locations in-place without adding/removing them. So this part looks as a good candidate for complete rewriting. [jacodb-core] Ensure that jar file is closed Two resource leaks fixed: a jar file wasn't closed after - its hash was computed; - its classes were indexed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## neo #295 +/- ##
============================================
+ Coverage 71.31% 71.67% +0.36%
- Complexity 2430 2446 +16
============================================
Files 254 254
Lines 14385 14457 +72
Branches 2106 2121 +15
============================================
+ Hits 10258 10362 +104
+ Misses 3257 3212 -45
- Partials 870 883 +13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[jacodb-core] Minor: reduce number of downloads
Two versions of the Keap lib are downloaded twice, not three times.
[jacodb-core] Make code model with ERS backend mutable incremental
As of this commit, ErsPersistenceImpl has got the following additional features:
TODO. PersistentLocationsRegistry looks overcomplicated. JcLocation implementations look as hacks in order to get JcLocation.isChanged() working, and in order to reindex mutated locations in-place without adding/removing them. So this part looks as a good candidate for complete rewriting.
[jacodb-core] Ensure that jar file is closed
Two resource leaks fixed: a jar file wasn't closed after