Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix warnings due to 2018.3 upgrade and default runtime becoming .NET 4.x
Testing status
Tests pass locally. I no longer see EditorXR-related warnings when recompiling in-editor or making player builds. Did a basic smoke test in editor, play mode, and player build.
Technical risk
Very low--mostly pre-processor defines and prefab API updates
Comments to reviewers
That first commit is pretty hefty, so let me break down the changes:
PrefabUtility.GetPrefabType
toPrefabUtility.GetPrefabAssetType
,PrefabUtility.CreatePrefab
toPrefabUtility.SavePrefabAsset
,PrefabUtility.FindPrefabRoot
toPrefabUtility.GetOutermostPrefabInstanceRoot
, andPrefabUtility.GetPrefabType
toPrefabUtility.GetPrefabInstanceStatus
PrefabUtility.InstantiatePrefab
. It is not possible to clone a non-prefab object whose children are prefabs and maintain prefab links.SerializeField
s have no setters. This results in a CS0649 warning, which was suppressed in the legacy runtime. For now, I have used #pragma warning disable to suppress the warning in the new 4.x runtime. I could also have fixed this by adding public setters, but they would have been unused, and in many cases would have added a lot of noise to our classes.