Skip to content

Fixing unclosed profiler marker #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimon merged 1 commit into from
Feb 9, 2023
Merged

Fixing unclosed profiler marker #1631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Packages/com.unity.inputsystem/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ however, it has to be formatted properly to pass verification tests.

## [Unreleased]

### Fixed

- Fixed unclosed profiler marker in `InvokeCallbacksSafe_AnyCallbackReturnsTrue` which would lead to eventually broken profiler traces in some cases like using `PlayerInput` (case ISXB-393).

## [1.5.0] - 2023-01-24

### Added
Expand Down
4 changes: 4 additions & 0 deletions Packages/com.unity.inputsystem/InputSystem/Utilities/DelegateHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,11 @@ public static bool InvokeCallbacksSafe_AnyCallbackReturnsTrue<TValue1, TValue2>(
try
{
if (callbacks[i](argument1, argument2))
{
callbacks.UnlockForChanges();
Profiler.EndSample();
return true;
}
}
catch (Exception exception)
{
Expand Down