Use templates to process custom attributes #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-tu
requested review from
arejayelle,
lucillecaillaud and
SanaJal
as code owners
SanaJal
reviewed
Jan 11, 2024
| @@ -1761,49 +1661,49 @@ void aiMeshSample<T>::fillSplitVertices(int split_index, aiPolyMeshData& data) c | |||
| copy_or_clear_3_to_4<abcC4, abcC3>((abcC4*)data.rgb, m_rgb_ref, split); | |||
| } | |||
|
|
|||
| static inline void copy_or_clear_vector(AttributeDataToTransfer dst[], const std::vector<AttributeData*>& src) | |||
There was a problem hiding this comment.
Should this be templated as well ?
SanaJal
pushed a commit
that referenced
this pull request
Jan 13, 2024
* First pass to extract redundant code and have one single template function * Use templates in other parts of aiMeshSchema to handle custom attributes. * Fix post-merge issues * Add specific supports for IC3f and IN4f attributes * Remove test code * Remove unused includes
thomas-tu
added a commit
that referenced
this pull request
Jan 30, 2024
* First pass to extract redundant code and have one single template function * Use templates in other parts of aiMeshSchema to handle custom attributes. * Fix post-merge issues * Add specific supports for IC3f and IN4f attributes * Remove test code * Remove unused includes
thomas-tu
added a commit
that referenced
this pull request
Feb 22, 2024
…580) * transfer harcoded array of float * change subD to aiPolyMesh * draft template function fix commit * working hardcoded * hardcoded transfer of data assigned to array of attributeData * set uv using custom attribute hardcoded * generalize using switch step1 * fix color and push isConstant to map arrays correctly * get resize count within the summary + better memory managment clean * remove commented testing function * remove commented function * working curve support * only read the one that we currently support * remove unused function * better memory managment * clean * Use templates to process custom attributes (#583) * First pass to extract redundant code and have one single template function * Use templates in other parts of aiMeshSchema to handle custom attributes. * Fix post-merge issues * Add specific supports for IC3f and IN4f attributes * Remove test code * Remove unused includes * working curve support * only read the one that we currently support * remove unused function * better memory managment * clean * working curve templated * templated copy data method * working curve support * remove unused function * working curve templated * templated copy data method * clean * clean * missing generalizaiton * rename att_int * apply formatting * remove static from function * revert static * remove copied function and clean readAttributes * remove comment * remove comment * Format --------- Co-authored-by: thomas-tu <45040865+thomas-tu@users.noreply.github.com> Co-authored-by: Thomas Tu <thomastu@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ticket/Jira #:
Use templated functions to get the custom attributes.