feat: distributed authority sample/expanded controls [MTT-9277] #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
changed the title
| { nameof(MobileGamepadState.ButtonJump), MapRuntimeControl(m_JumpAction) }, | ||
| { nameof(MobileGamepadState.ButtonInteract), MapRuntimeControl(m_InteractAction) }, | ||
| { nameof(MobileGamepadState.ButtonSprint), MapRuntimeControl(m_SprintAction) }, | ||
| // will re-visit to evaluate if this button is necessary |
There was a problem hiding this comment.
do you want to revisit it in a later PR?
There was a problem hiding this comment.
Yeah, we'll revisit if we need this button in the UI icons PR.
| public event Action<string, Vector2> JoystickStateChanged; | ||
|
|
||
| /// <summary> | ||
| /// This method let the UI updates when a property bound with <see cref="BindingMode.ToTarget"/> is calling it. |
There was a problem hiding this comment.
"lets the UI update"
| } | ||
|
|
||
| /// <summary> | ||
| /// This method lets the Input system updates when a property value is changed. |
There was a problem hiding this comment.
same here and below
| /// The UI is bound to <see cref="RightJoystickTop"/> and <see cref="RightJoystickLeft"/> | ||
| /// which converts the Vector2 position into a percent <see cref="StyleLength"/>. | ||
| /// <para>The <see cref="TouchScreenBehaviour"/> is reading the UI pointer | ||
| /// to directly write the delta in this property, which in returns updates the VisualElement position.</para> |
|
The controller controls work well! With the mobile ones I have some issues:
|
What was challenging about the jumping? Is it something a follow-up PR could address? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the skeleton mobile controls UI to the project. Mobile controls can be debugged inside the editor by toggling the following field inside the Bootstrap scene:
A result of this bootstrapping mobile work is that there's a wrapper between the UI and the project's inputs. So, at a high level, UI captures the value of a joystick or a button and routes them to the associated input system action. The result of this is some wrapper Input classes were removed or deprecated, as the game should fetch the input data from the new
GameInputclass, instead of referencing actions independently. The reason for this is thatInputSystemManagernow handles what platform the game is on and subsequently what control scheme to be on. Thus, reading from GameInput will track the currently enabled actions.Note: having a gamepad connected while debugging mobile controls will override both the virtual joystick inputs, so make sure to test gamepad when outside mobile debug mode.
Issue Number(s)
MTT-9277
Contribution checklist