Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Renaming connection methods in main menu #382

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Bug Fix: Renaming connection methods in main menu #382

merged 3 commits into from
Oct 19, 2021

Conversation

jilfranco-unity
Copy link
Contributor

@jilfranco-unity jilfranco-unity commented Oct 19, 2021 •
edited
Loading

Jira ticket here

In main menu, changed labels of connection types "RELAY" and "U-RELAY" to "PHOTON RELAY" and "UNITY RELAY" respectively

Before:
connectionTypeBefore

After:
connectionTypeAfter

@unity-cla-assistant
Copy link

unity-cla-assistant commented Oct 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jilfranco-unity jilfranco-unity self-assigned this Oct 19, 2021
@jilfranco-unity jilfranco-unity changed the base branch from main to develop October 19, 2021 15:29
@jilfranco-unity jilfranco-unity added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers type:bug Bug Report labels Oct 19, 2021
SamuelBellomo
SamuelBellomo previously approved these changes Oct 19, 2021
View reviewed changes
@SamuelBellomo
Copy link
Contributor

Dunno if there's a way to make the text less small? Just for readability/design's sake?

@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Oct 19, 2021
LukeStampfli
LukeStampfli previously approved these changes Oct 19, 2021
View reviewed changes
@jilfranco-unity
Copy link
Contributor Author

Dunno if there's a way to make the text less small? Just for readability/design's sake?

How's this? I made the buttons wider and was able to take the text size from 14 to 18
image

@jilfranco-unity
Copy link
Contributor Author

Pushed that label size increase change!

@jilfranco-unity jilfranco-unity merged commit 79af8b0 into develop Oct 19, 2021
@jilfranco-unity jilfranco-unity deleted the bug/renaming_connection_methods branch October 19, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@LukeStampfli LukeStampfli Awaiting requested review from LukeStampfli

Assignees

@jilfranco-unity jilfranco-unity

Labels
0-URGENT Blocker for a release and needs to be merged ASAP 1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly type:bug Bug Report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jilfranco-unity @unity-cla-assistant @SamuelBellomo @LukeStampfli @fernando-cortez