Feature: Art and Sound Pass for Vandal Imp Tossed Attack [MTT-2732] #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up any old assets (cherry picked from commit baef02ba6280f7d48eba6e8305b5af24f7340361)
jilfranco-unity
added
1-Needs Review
|
Contribution check list says there are tests added? |
Co-authored-by: Sam Bellomo <71790295+SamuelBellomo@users.noreply.github.com>
My b, didn't mean to check this! :P |
… the tossed attack explosion effect that made late join clients see explosion effects everywhere
… all geometry and to instead be soft particles that blend into the ground to fix the look of them clipping into the ground
jilfranco-unity
removed
the
2-Reviewed with Comments
LPLafontaineB
added
2-One More Review
LPLafontaineB
previously approved these changes
Aug 5, 2022
fernando-cortez
previously approved these changes
Aug 5, 2022
…he surrounding imps a bit so that he fit in better
jilfranco-unity
dismissed stale reviews from fernando-cortez and LPLafontaineB
via
18ccf9d
|
Moved the vandal imp to be closer to the boss door! I also rearranged the surrounding imps a bit so that he fit in better :)
|
LPLafontaineB
approved these changes
Aug 10, 2022
fernando-cortez
approved these changes
Aug 15, 2022
fernando-cortez
added
3-Good to Merge
and removed
2-One More Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An art and sound pass for the Vandal Imp tossed attack! Created a bunch of fancy new VFX and worked with Fernando to implement them for the tossed attack. Also cut up our existing tossed attack sound effect to work with this version.
(cherry picked from commit baef02ba6280f7d48eba6e8305b5af24f7340361): These changes were originally in a branch based off of the Network Rigid Body branch that has since been merged into develop, so to keep things clean, I've cherry picked them into this branch which is based off of develop.
Here's how it looks now :)
TossedAttack.mp4
Issue Number(s)
Jira ticket [MTT-2732]
Contribution checklist