-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: synced WinState was causing issues on a replay attempt (MTT-4490) #724
Merged
pdeschain
merged 6 commits into
develop
from
pdeschain/winstate-networkbehaviour-cleanup
Aug 31, 2022
Merged
fix: synced WinState was causing issues on a replay attempt (MTT-4490) #724
pdeschain
merged 6 commits into
develop
from
pdeschain/winstate-networkbehaviour-cleanup
Aug 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it the game to main menu
pdeschain
added
2-Easy
This PR is trivial and can be reviewed quickly
1-Needs Review
PR needs attention from the assignee and reviewers
labels
Aug 30, 2022
SamuelBellomo
previously approved these changes
Aug 30, 2022
SamuelBellomo
added
2-One More Review
One review in, one to go
and removed
1-Needs Review
PR needs attention from the assignee and reviewers
labels
Aug 30, 2022
LPLafontaineB
previously approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is fixing MTT-4487 as well
fernando-cortez
previously approved these changes
Aug 30, 2022
…tiplayer.samples.coop into pdeschain/winstate-networkbehaviour-cleanup
This reverts commit 9688fa0.
pdeschain
dismissed stale reviews from fernando-cortez, LPLafontaineB, and SamuelBellomo
via
August 31, 2022 15:37
984c066
fernando-cortez
approved these changes
Aug 31, 2022
SamuelBellomo
approved these changes
Aug 31, 2022
LPLafontaineB
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Was:
Now:
Issue Number(s)
MTT-4490
Contribution checklist