feat: Bridge classes removal, Namespace cleanup [MTT-4014] #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch, updated the scenes and prefabs accordingly
…, merged data objects with server class where it was possible
…zation trifecta refactoring
Removed NetworkCharacterState and CharacterClassContainer, merged into ServerCharacter
pdeschain
added
the
5-Design Review
pdeschain
changed the title
BossRoom state now lives in the scene root and is easier to locate.
removed a duiplicate NetworkAvatarGuidHandler that caused problems on PlayerAvatar
pdeschain
added
1-Needs Review
Assets/Scripts/Gameplay/GameplayObjects/AnimationCallbacks/AnimatorTriggeredSpecialFX.cs
Show resolved
Hide resolved
# Conflicts: # Assets/Scenes/BossRoom/DungeonBossRoom.unity # Assets/Scenes/BossRoom/DungeonEntrance.unity # Assets/Scenes/BossRoom/DungeonTransition.unity
removing useless "private"
SamuelBellomo
previously approved these changes
Sep 26, 2022
…gies/com.unity.multiplayer.samples.coop into pdeschain/project-cleanup
SamuelBellomo
previously approved these changes
Sep 26, 2022
pdeschain
added
2-One More Review
fernando-cortez
previously approved these changes
Sep 26, 2022
fernando-cortez
previously approved these changes
Sep 26, 2022
SamuelBellomo
approved these changes
Sep 26, 2022
fernando-cortez
approved these changes
Sep 26, 2022
pdeschain
added
3-Good to Merge
and removed
2-One More Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NetworkCharacterState and CharacterClassContainer have been removed and merged into ServerCharacter. All the API usage has been adjusted accordingly. In multiple places we're now using ServerCharacter.ClientCharacterVisualization instead of using (now removed) ClientCharacter class (that used to serve as a bridge to ClientCharacterVisualization).
Door and Floor switch's client and server code has also been merged.
Namespaces have been adjusted to match asmdefs.
Many variables and events were renamed (fixing capitalization or due to type changes etc).
Issue Number(s)
MTT-4014
Contribution checklist