Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shield charge trigger reset & reuse cooldown populated [MTT-4100] #742

Merged
merged 5 commits into from
Sep 26, 2022
Merged

fix: shield charge trigger reset & reuse cooldown populated [MTT-4100] #742

merged 5 commits into from
Sep 26, 2022

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Sep 23, 2022 •
edited
Loading

Description

This PR fixes the bug where the Tank would get stuck in its charge animation. The charge start animation trigger was not reset when stopped, meaning if the action was started multiple times it would correctly stop, but go back into the charge animation. As an added safety (more just good practice), the reuse time cooldown field has been populated with a sensible value (1.2s).

Issue Number(s)

MTT-4100

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Sep 23, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Sep 23, 2022
View reviewed changes
@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Sep 26, 2022
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Sep 26, 2022
@LPLafontaineB LPLafontaineB added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Sep 26, 2022
@fernando-cortez fernando-cortez merged commit b139fb5 into develop Sep 26, 2022
@fernando-cortez fernando-cortez deleted the fix/shield-charge-reuse-cooldown branch September 26, 2022 19:43
SamuelBellomo added a commit that referenced this pull request Sep 26, 2022
@SamuelBellomo
Merge branch 'develop' into sam/chore/bump-unity-2021.3.10f1
bbca4ef 
* develop:
  feat: upgrade lobby [MTT-3962][MTT-4105][MTT-4052] (#737)
  fix: shield charge trigger reset & reuse cooldown populated [MTT-4100] (#742)

# Conflicts:
#	CHANGELOG.md
#	Packages/manifest.json
#	Packages/packages-lock.json
@SamuelBellomo SamuelBellomo mentioned this pull request Oct 3, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

Assignees

@SamuelBellomo SamuelBellomo

@LPLafontaineB LPLafontaineB

Labels
0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernando-cortez @SamuelBellomo @LPLafontaineB