Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mage heal fx plays out for whole duration & stays at spawn rotation [MTT-4476] #771

Merged
merged 4 commits into from
Oct 31, 2022
Merged

fix: mage heal fx plays out for whole duration & stays at spawn rotation [MTT-4476] #771

merged 4 commits into from
Oct 31, 2022

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Oct 20, 2022 •
edited
Loading

Description

This quick PR re-hooks up items on SpecialFXGraphic component on the mage heal fx graphic to allow waiting for the FX's ParticleEffects to play out to completion before being shutdown.

As an added visual fix, the flexibility to keep an FX at spawn rotation has been added and applied to the heal FX. The heal FX's ParticleEffects have been subsequently modified to Local space simulation for a visual parity & improvement, thanks to @jilfranco-unity.

Issue Number(s)

MTT-4476

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@fernando-cortez
mage heal fx SpecialFXGraphic components re-hooked up to enable waiti…
9a404d4 
…ng for completion, fx stays at spawn rotation
@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 20, 2022
@LPLafontaineB LPLafontaineB added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 24, 2022
jilfranco-unity
jilfranco-unity reviewed Oct 24, 2022
View reviewed changes
Copy link
Contributor

@jilfranco-unity jilfranco-unity left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve these changes from the visual sense (since I helped a little along the way so we could get them to look as intended), but I'm not sure if I should approve on github since I did help a bit? :0

@fernando-cortez fernando-cortez merged commit 985b74b into develop Oct 31, 2022
@fernando-cortez fernando-cortez deleted the fix/mage-heal-fx-not-completing branch October 31, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilfranco-unity jilfranco-unity jilfranco-unity left review comments

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

Assignees

@SamuelBellomo SamuelBellomo

@LPLafontaineB LPLafontaineB

Labels
2-Easy This PR is trivial and can be reviewed quickly 2-One More Review One review in, one to go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fernando-cortez @jilfranco-unity @LPLafontaineB @SamuelBellomo