Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: EnemyPortals' VFX get disabled/enabled when crystals are broken [MTT-4893] #784

Merged
merged 3 commits into from
Dec 15, 2022
Merged

fix: EnemyPortals' VFX get disabled/enabled when crystals are broken [MTT-4893] #784

merged 3 commits into from
Dec 15, 2022

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Nov 14, 2022 •
edited
Loading

Description

This PR hooks up the Breakable component reference back into EnemyPortals, such that the EnemyPortal modifies the IsBroken NetworkVariable of the Breakable component, leading to VFX disabling/enabling again.

Issue Number(s)

MTT-4893

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers DO NOT MERGE Do not merge this PR! labels Nov 14, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Nov 17, 2022
View reviewed changes
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers DO NOT MERGE Do not merge this PR! labels Dec 14, 2022
@fernando-cortez fernando-cortez added 1-Needs Review PR needs attention from the assignee and reviewers and removed 3-Good to Merge labels Dec 15, 2022
@fernando-cortez fernando-cortez merged commit 12b0ef4 into develop Dec 15, 2022
@fernando-cortez fernando-cortez deleted the fix/enemyspawners-turn-off branch December 15, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

Assignees

@LPLafontaineB LPLafontaineB

Labels
1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fernando-cortez @SamuelBellomo @pdeschain @LPLafontaineB