Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplifying reconnection #804

Merged
merged 13 commits into from
Mar 6, 2023
Merged

feat: simplifying reconnection #804

merged 13 commits into from
Mar 6, 2023

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Jan 31, 2023 •
edited
Loading

Description

This PR uses the ConnectionMethod to simplify the reconnection flow. Now ClientReconnectingState doesn't need to know if the client was connected through Lobby or Direct IP before attempting to reconnect and instead offloads that responsibility to the ConnectionMethod that it was initially configured with. This also adds the possibility to fail early and stop retrying to reconnect if the lobby doesn't exist anymore.

Issue Number(s)

None

Contribution checklist

  • [n/a] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [n/a] JIRA ticket ID is in the PR title or at least one commit message
  • [n/a] Include the ticket ID number within the body message of the PR to create a hyperlink
  • [n/a] An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Feb 7, 2023
@LPLafontaineB LPLafontaineB marked this pull request as ready for review February 7, 2023 14:36
fernando-cortez
fernando-cortez previously approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 1, 2023
@LPLafontaineB LPLafontaineB enabled auto-merge (squash) March 1, 2023 17:53
@LPLafontaineB LPLafontaineB merged commit db90813 into develop Mar 6, 2023
@LPLafontaineB LPLafontaineB deleted the feature/simplifying-reconnection branch March 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

Assignees

@SamuelBellomo SamuelBellomo

Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LPLafontaineB @fernando-cortez @SamuelBellomo