feat: replacing polling for lobby updates with LobbyEvents [MTT-5425] #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPLafontaineB
requested review from
fernando-cortez and
RikuTheFuffs
and removed request for
SamuelBellomo
LPLafontaineB
added
1-Needs Review
…bby to be properly updated
SamuelBellomo
previously approved these changes
Mar 10, 2023
Co-authored-by: Sam Bellomo <71790295+SamuelBellomo@users.noreply.github.com>
SamuelBellomo
previously approved these changes
Mar 20, 2023
fernando-cortez
previously approved these changes
Mar 20, 2023
LPLafontaineB
dismissed stale reviews from fernando-cortez and SamuelBellomo
via
68efccc
* issue was because it was being set before the call to the UI gameobject's Awake
SamuelBellomo
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the polling we are currently doing to get updates to the lobby we have joined. It instead replaces it with the LobbyEvent feature which uses Wire to create channels that clients can subscribe to. These channels then send updates only when it is needed. In doing so, we save a lot of bandwidth to the Lobby Service.
This PR also fixes a bug in the UpdateRunner that was using the wrong delta time when updating subscribers. This was causing the Heartbeat request we meant to send regularly to the Lobby Service to be sent much less frequently.
Issue Number(s)
MTT-5425
Contribution checklist