Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing connection management test [MTT-4492][MTT-6242] #826

Merged
merged 9 commits into from
Apr 26, 2023
Merged

fix: fixing connection management test [MTT-4492][MTT-6242] #826

merged 9 commits into from
Apr 26, 2023

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Apr 24, 2023 •
edited
Loading

Description

This PR adds the OnServerStopped event, added in NGO 1.4.0, to the ConnectionManager and the ConnectionStates. This allows the detection of unexpected shutdowns on the server. One of the connection management tests was ignored because there was no mechanism to detect this, but now it can be enabled.

No events were added for OnClientStarted and OnClientStopped in the ConnectionManager because for this system OnClientConnected and OnClientDisconnect are more relevant.

Issue Number(s)

MTT-4492 & MTT-6242

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [n/a] An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB added 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 24, 2023
@LPLafontaineB LPLafontaineB marked this pull request as ready for review April 24, 2023 17:43
@LPLafontaineB
Copy link
Contributor Author

Marking this as "On Hold" until the update to NGO 1.4.0 is done

@fernando-cortez fernando-cortez self-assigned this Apr 26, 2023
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 26, 2023
SamuelBellomo
SamuelBellomo previously approved these changes Apr 26, 2023
View reviewed changes
@LPLafontaineB LPLafontaineB enabled auto-merge (squash) April 26, 2023 20:22
@LPLafontaineB LPLafontaineB merged commit 8bcf2d6 into develop Apr 26, 2023
@LPLafontaineB LPLafontaineB deleted the fix/fixing-connection-management-test branch April 26, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

Assignees

@fernando-cortez fernando-cortez

Labels
3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LPLafontaineB @SamuelBellomo @fernando-cortez