Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: network object pool cleanup #827

Merged
merged 2 commits into from
Apr 25, 2023
Merged

chore: network object pool cleanup #827

merged 2 commits into from
Apr 25, 2023

Conversation

LPLafontaineB
Copy link
Contributor

Description

This is a trivial PR to remove another method from the NetworkObjectPool that is not needed.

Issue Number(s)

None

Contribution checklist

  • [n/a] Tests have been added for boss room and/or utilities pack
  • [n/a] Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [n/a] JIRA ticket ID is in the PR title or at least one commit message
  • [n/a Include the ticket ID number within the body message of the PR to create a hyperlink
  • [n/a] An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 24, 2023
@LPLafontaineB LPLafontaineB enabled auto-merge (squash) April 25, 2023 17:30
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 25, 2023
@LPLafontaineB LPLafontaineB merged commit d910235 into develop Apr 25, 2023
@LPLafontaineB LPLafontaineB deleted the chore/network-pool-cleanup branch April 25, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

Assignees
No one assigned
Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LPLafontaineB @fernando-cortez