Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to editor version 2022.3 LTS [MTT-6341] #840

Merged
merged 36 commits into from
Jun 7, 2023
Merged

feat: update to editor version 2022.3 LTS [MTT-6341] #840

merged 36 commits into from
Jun 7, 2023

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented May 9, 2023 •
edited
Loading

Description

This PR updates BR to use editor version 2022.3 LTS. It also fixes some issues that came during the upgrade:

  • Removes unneeded DisableCollidersOnAwake monobehaviours in scenes where colliders are already deleted
  • Uses the AI Navigation package from the registry instead of the previous version accessible only through git
  • Updates size of standards check job's flavor to fix out of memory issues in CI
  • Upgrades bokken image used for iOS build job in CI
  • Upgrades Tools package to version 2.0.0 pre-3

Issue Number(s)

MTT-6341

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB added 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. 1-Needs Review PR needs attention from the assignee and reviewers labels May 9, 2023
@LPLafontaineB LPLafontaineB changed the title feat: update to editor version 2022.2 feat: update to editor version 2022.3 LTS [MTT-6341] May 31, 2023
@LPLafontaineB LPLafontaineB marked this pull request as ready for review May 31, 2023 16:36
SamuelBellomo
SamuelBellomo reviewed May 31, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
SamuelBellomo
SamuelBellomo previously approved these changes May 31, 2023
View reviewed changes
@LPLafontaineB LPLafontaineB removed the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Jun 1, 2023
fernando-cortez
fernando-cortez previously approved these changes Jun 1, 2023
View reviewed changes
fernando-cortez
fernando-cortez previously approved these changes Jun 5, 2023
View reviewed changes
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Jun 5, 2023
@jilfranco-unity
Copy link
Contributor

@LPLafontaineB made some tiny fixes!

  • corrected a shader that got reset to the wrong blending mode
  • pushed some shaders that had new properties added in the upgrade
  • rebaked lighting (there were some baking artifacts around the lava pits)

jilfranco-unity
jilfranco-unity approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@jilfranco-unity jilfranco-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good art wise!

@LPLafontaineB LPLafontaineB merged commit 058dfa7 into develop Jun 7, 2023
@LPLafontaineB LPLafontaineB deleted the feat/update-to-2022-lts branch June 7, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo left review comments

@jilfranco-unity jilfranco-unity jilfranco-unity approved these changes

@fernando-cortez fernando-cortez fernando-cortez left review comments

Assignees

@SamuelBellomo SamuelBellomo

Labels
3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LPLafontaineB @jilfranco-unity @SamuelBellomo @fernando-cortez