-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to lobby 1.1.0 [MTT-7092] [MTT-5665] [MTT-7101] [MTT-5708] #860
Conversation
…from lobby updates from the service
This reverts commit f1893a3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I caught an exception as the host and on clients when hitting stop in the editor while in the character select screen. I'll send the log files offline.
… at the earliest time possible
…a lobby or delete it
…ew temporary catch for edge case exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not seeing the same errors as before. Looks good!
Description
This PR upgrades BR to use Lobby 1.1.0. It leverages a small new lobby feature to lock lobbies at creation and unlock them later when the server is created and Relay is ready to allow clients to join. This prevents clients from joining too early which would lead to an exception about the relay allocation not being found (while possible, this edge-case was still very unlikely, we haven't noticed it in any playtest).
This PR also fixes an issue where we would automatically send back an update request to Lobby whenever updating our local lobby data, even when that update came from the service. Since there are no changes to this data that needs to be updated during a game session, the periodic update mechanism has been removed entirely. The only updates we need to send are when setting up the relay integration, which is done when starting the host and when joining as a client.
It also removes the explicit reference we have to Wire in our package manifest, which we do not need since Wire is a dependency of Lobby.
Issue Number(s)
MTT-7092, MTT-5665, MTT-7101, & MTT-5708
Contribution checklist