Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to lobby 1.1.0 [MTT-7092] [MTT-5665] [MTT-7101] [MTT-5708] #860

Merged
merged 21 commits into from
Aug 31, 2023

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Aug 15, 2023

Description

This PR upgrades BR to use Lobby 1.1.0. It leverages a small new lobby feature to lock lobbies at creation and unlock them later when the server is created and Relay is ready to allow clients to join. This prevents clients from joining too early which would lead to an exception about the relay allocation not being found (while possible, this edge-case was still very unlikely, we haven't noticed it in any playtest).

This PR also fixes an issue where we would automatically send back an update request to Lobby whenever updating our local lobby data, even when that update came from the service. Since there are no changes to this data that needs to be updated during a game session, the periodic update mechanism has been removed entirely. The only updates we need to send are when setting up the relay integration, which is done when starting the host and when joining as a client.

It also removes the explicit reference we have to Wire in our package manifest, which we do not need since Wire is a dependency of Lobby.

Issue Number(s)

MTT-7092, MTT-5665, MTT-7101, & MTT-5708

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB added the 1-Needs Review PR needs attention from the assignee and reviewers label Aug 15, 2023
@LPLafontaineB LPLafontaineB marked this pull request as ready for review August 15, 2023 18:56
@LPLafontaineB LPLafontaineB requested a review from a team as a code owner August 15, 2023 18:56
@LPLafontaineB LPLafontaineB marked this pull request as draft August 15, 2023 18:59
@LPLafontaineB LPLafontaineB marked this pull request as ready for review August 17, 2023 15:43
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I caught an exception as the host and on clients when hitting stop in the editor while in the character select screen. I'll send the log files offline.

@LPLafontaineB LPLafontaineB changed the title feat: upgrade to lobby 1.1.0 [MTT-7092] [MTT-5665] [MTT-7101] feat: upgrade to lobby 1.1.0 [MTT-7092] [MTT-5665] [MTT-7101] [MTT-5708] Aug 23, 2023
@LPLafontaineB LPLafontaineB removed the 2-Reviewed with Comments PR requires owner's attention label Aug 23, 2023
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing the same errors as before. Looks good!

@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 30, 2023
@LPLafontaineB LPLafontaineB merged commit 774b3f8 into develop Aug 31, 2023
@LPLafontaineB LPLafontaineB deleted the feat/upgrade-to-lobby-1.1.0 branch August 31, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants