Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when batch size is a non-multiple of sequence length #2661

Merged
merged 2 commits into from
Oct 3, 2019
Merged

Fix bug when batch size is a non-multiple of sequence length #2661

merged 2 commits into from
Oct 3, 2019

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Oct 2, 2019

  • In PPO trainer, always round batch size down to the nearest multiple of sequence length, with at least one sequence always (same as 0.9 and SAC behavior).
  • Add test to detect this error

Adjust batch size s.t is multiple of seq length
6837745 
Add test to detect this error
@ervteng ervteng requested a review from harperj October 2, 2019 20:13
harperj
harperj approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@harperj harperj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- this should return us to similar behavior to what we had previously

@ervteng ervteng merged commit 80c1af3 into develop Oct 3, 2019
@ervteng ervteng deleted the develop-sequencelengthbug branch October 8, 2019 21:54
ervteng pushed a commit that referenced this pull request Oct 9, 2019
Fix bug when batch size is a non-multiple of sequence length (#2661)
7dfb2d7
@ervteng ervteng mentioned this pull request Oct 9, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion left review comments

@harperj harperj harperj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ervteng @harperj @chriselion