Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up slow unit test #2847

Merged
merged 1 commit into from
Nov 4, 2019
Merged

speed up slow unit test #2847

merged 1 commit into from
Nov 4, 2019

Conversation

chriselion
Copy link
Contributor

Takes the test time for

pytest ml-agents/mlagents/trainers/tests/test_simple_rl.py::test_simple_sac

from 17.63 seconds down to 11.64 seconds on my laptop.

@chriselion chriselion requested a review from ervteng November 4, 2019 18:12
ervteng
ervteng approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@ervteng ervteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable - the speedup is almost certainly coming from the batch size and hidden units reduction

@chriselion
Copy link
Contributor Author

That helped a bit, along with dropping the number of steps

@chriselion chriselion merged commit 0c75d91 into develop Nov 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the develop-speed-up-slow-test branch November 4, 2019 19:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ervteng ervteng ervteng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselion @ervteng