Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch size issue with BC #2965

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Fix batch size issue with BC #2965

merged 1 commit into from
Nov 25, 2019

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Nov 25, 2019

When num_batches_per_epoch exceeded the number of batches in the buffer and recurrent was enabled, BC trainer used the wrong batch size to compute how many batches were in the buffer, resulting in a Tensorflow error (wrong size for placeholder).

This PR fixes that issue and adds a test.

@ervteng ervteng requested a review from chriselion November 25, 2019 21:52
@ervteng ervteng merged commit 4e8c992 into develop Nov 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the develop-bcbatch branch November 25, 2019 22:00
chriselion pushed a commit that referenced this pull request Nov 25, 2019
chriselion pushed a commit that referenced this pull request Nov 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants