handle mismatch between brain and metacurriculum #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Dec 10, 2019
| @@ -32,9 +32,9 @@ def __init__(self, curriculum_folder: str): | |||
| try: | |||
| for curriculum_filename in os.listdir(curriculum_folder): | |||
| # This process requires JSON files | |||
| if not curriculum_filename.lower().endswith(".json"): | |||
| brain_name, extension = os.path.splitext(curriculum_filename) | |||
There was a problem hiding this comment.
So far I don't think this has tripped anybody up. But the old behavior would mean that a brain with a . in the name wouldn't be able to match up with the metacurriculum, because curriculum_filename.split(".")[0] would take the only the filename up to the first . instead of the last one.
ervteng
approved these changes
Dec 12, 2019
added 2 commits
December 11, 2019 18:30
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually by renaming a WallJump curriculum file, also added unit tests.