Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use absolute path in error #3230

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Conversation

chriselion
Copy link
Contributor

I think conda might do something weird with the working directory; there have been a few issues with users passing bad paths to mlagents-learn. This replaces the relative path in the exception with the absolute path, so hopefully it's easier to see where it's trying (and failing) to load from.

before:

mlagents.trainers.exception.TrainerConfigError: Config file could not be found at bad.yaml.

after:

mlagents.trainers.exception.TrainerConfigError: Config file could not be found at /Users/chris.elion/code/ml-agents/bad.yaml.

@chriselion chriselion requested a review from harperj January 15, 2020 21:02
Copy link
Contributor

@harperj harperj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chriselion chriselion merged commit 5adea00 into master Jan 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-MLA-531-error-abs-path branch January 15, 2020 21:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants