Make CollectObservations take a VectorSensor #3352
Conversation
|
Seems OK. I'm not sure it actually makes the API any smaller though, just moves it to VectorSensor. |
|
Yes, but it does simplify the Agent code (since it does not forward the calls to addobservation for every type of observation. |
|
But it also couples the public interface of Agent more closely to VectorSensor, whereas before they were decoupled (and we could theoretically change the implementation of how AddVectorObs worked) |
|
I retract my objections. Make it so! |
Co-Authored-By: Chris Elion <chris.elion@unity3d.com>
Co-Authored-By: Chris Elion <chris.elion@unity3d.com>
Co-Authored-By: Chris Elion <chris.elion@unity3d.com>
Co-Authored-By: Chris Elion <chris.elion@unity3d.com>
|
|
||
| namespace MLAgents.Sensor | ||
| namespace MLAgents |
There was a problem hiding this comment.
What's the reason for this change? Should we (roughly) keep the namespaces 1:1 with the subdirectories?
There was a problem hiding this comment.
Yes but now the user would have to import both MLAgents and MLAgents.Sensors when implementing an Agent that has a CollectObservation implementation
There was a problem hiding this comment.
All right. Removed the MLAgents.Sensor namespace alltogether
|
|
chriselion
changed the title
No description provided.