[bug-fix] Use correct agent_ids for demo loader #3464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
When the agent_id changes, the demo loader tries to use the old agent_id to access the agent in the BatchedAgentStep. This caused a crash in 0.14.0 onwards. We now just always use the first agent so that changes in agent_id don't cause a crash.
Note that this fix will have to be coupled with a fix on the C# DemonstrationRecorder to properly log the done signals in the demo. After the C# fix happens, we will add new test demos so that we can catch similar issues in the future.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Github issue: #3455
Unity Forum: https://forum.unity.com/threads/imitation-learning-error-message.829188/
Types of change(s)
Checklist