Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug-fix] Use correct agent_ids for demo loader #3464

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Feb 18, 2020

Proposed change(s)

When the agent_id changes, the demo loader tries to use the old agent_id to access the agent in the BatchedAgentStep. This caused a crash in 0.14.0 onwards. We now just always use the first agent so that changes in agent_id don't cause a crash.

Note that this fix will have to be coupled with a fix on the C# DemonstrationRecorder to properly log the done signals in the demo. After the C# fix happens, we will add new test demos so that we can catch similar issues in the future.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Github issue: #3455
Unity Forum: https://forum.unity.com/threads/imitation-learning-error-message.829188/

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • I have added tests that prove my fix is effective or that my feature works - will re-record demos after C# fix is implemented
  • I have added updated the changelog (if applicable)
  • I have added necessary documentation (if applicable)
  • I have updated the migration guide (if applicable)

@ervteng ervteng merged commit 596c364 into master Feb 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-agentid-demoloader branch February 18, 2020 19:23
@ervteng ervteng mentioned this pull request Feb 18, 2020
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants