Change checkpoint suffix to "ckpt" #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tensorflow doesn't prescribe any particular file suffix for checkpoint files, but they are commonly referred to as "ckpt" as a shorthand for "checkpoint". However ours is somewhat confusingly "cptk". This change simply changes our checkpoint suffix to "ckpt".
chriselion
approved these changes
Feb 18, 2020
|
Changelog updated. Thanks 🚢 |
chriselion
approved these changes
Feb 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tensorflow doesn't prescribe any particular file suffix for checkpoint files, but they
are commonly referred to as "ckpt" as a shorthand for "checkpoint". However ours
is somewhat confusingly "cptk". This change simply changes our checkpoint suffix
to "ckpt".
Proposed change(s)
Change the checkpoint file suffix to "ckpt".
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Brought up in #3456
Types of change(s)
Minor interface change.
Checklist
I have added tests that prove my fix is effective or that my feature
This should be covered by existing testing.
I have added updated the changelog (if applicable)
I have added necessary documentation (if applicable)
I have updated the migration guide (if applicable)
For the above, I believe this should not affect loading or saving existing training runs,
and probably is below the threshold of requiring an entry in the changelog (but open
to disagreement on this).
Other comments