Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused methods from Utilities.cs #3495

Merged
merged 4 commits into from
Feb 26, 2020
Merged

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Feb 25, 2020

Proposed change(s)

Remove unused methods from Utilities.cs

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

com.unity.ml-agents/Runtime/Utilities.cs Show resolved Hide resolved
/// Amount to shift the elements to the left by
/// </param>
/// </summary>
public static void ShiftLeft<T>(List<T> list, int shiftAmount)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did not have any tests for these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope
image

Chris Elion and others added 2 commits February 25, 2020 15:52
Co-Authored-By: Vincent-Pierre BERGES <vincentpierre@unity3d.com>
@chriselion chriselion merged commit 298f844 into master Feb 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-cleanup-utilities branch February 26, 2020 00:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants