Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop package docs #3551

Merged
merged 32 commits into from
Mar 4, 2020
Merged

Develop package docs #3551

merged 32 commits into from
Mar 4, 2020

Conversation

mmattar
Copy link

@mmattar mmattar commented Mar 3, 2020

Proposed change(s)

  • Added the main Documentation~ page for the unity package
  • Updated the repo README to emphasize releases
  • Simplified the Installation page
  • Removed reference of package installation in the virtual env page

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@mmattar mmattar requested a review from shihzy March 3, 2020 07:59
To use this package, you must have the following 3rd party products:

* <TBC>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could link to our python install docs here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is another Unity (Python) package considered a third-party?

Copy link
Contributor

@surfnerd surfnerd Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, maybe we need a different section though to call that out as a requirement for training.

# About Unity MLAgents package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the Package Starter Kit I think this file is supposed to be named com.unity.ml-agents.md.

README.md Show resolved Hide resolved
Note that this package does not contain the machine learning algorithms for training
behaviors. It relies on a Python package to orchestrate the training. This package
only enables instrumenting a Unity scene and setting it up for training.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to reference inference via the Barracuda package?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. @surfnerd - is there a way to link to other packages here? We can just reference them by name too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can link to their docs on the unity site.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/Installation.md Outdated Show resolved Hide resolved
docs/Installation.md Outdated Show resolved Hide resolved
If you are a researcher interested in a discussion of Unity as an AI platform, see a pre-print
of our [reference paper on Unity and the ML-Agents Toolkit](https://arxiv.org/abs/1809.02627).

If you use Unity or the ML-Agents Toolkit to conduct research, we ask that you cite the following

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about we "request" instead of asking them to cite?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I follow...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that we use

"... conduct research, we request that you cite the following ..."

instead of

"... conduct research, we ask that you cite the following ... "

README.md Show resolved Hide resolved
com.unity.ml-agents/Documentation~/index.md Outdated Show resolved Hide resolved
com.unity.ml-agents/Documentation~/index.md Show resolved Hide resolved
com.unity.ml-agents/Documentation~/index.md Outdated Show resolved Hide resolved
com.unity.ml-agents/Documentation~/index.md Outdated Show resolved Hide resolved
docs/Using-Virtual-Environment.md Show resolved Hide resolved
docs/Using-Virtual-Environment.md Show resolved Hide resolved
@mmattar mmattar merged commit fa2eb31 into master Mar 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-package-docs branch March 4, 2020 23:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants