[bug-fix] Fix crash when demo size is smaller than batch size #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
When we had less demos than batch_size, GAIL was being updated with the maximum demonstration number but the rest of PPO was updated with
batch_sizeelements. This caused an error as all updates happen on the same sess.run call.SAC was unaffected since reward signals are updated independently of the Policy.
This PR now oversamples the demonstrations so that there is always
batch_sizeelements in the GAIL update.Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
#3385
https://jira.unity3d.com/browse/MLA-616
Types of change(s)
Checklist
Other comments