-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the notebooks from the github repository. #3704
Conversation
ml-agents/setup.py
Outdated
@@ -56,7 +56,6 @@ def run(self): | |||
# Test-only dependencies should go in test_requirements.txt, not here. | |||
"grpcio>=1.11.0", | |||
"h5py>=2.9.0", | |||
"jupyter", | |||
"matplotlib", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove matplotlib too?
I don't love notebooks in general. But I worry that this doesn't give us any way (that's under source control) to test the LL API or gym interface. |
By test, you mean testing or letting our users try it out? If it is testing, I think we should have a better way to do it. For letting our users try it out, I think we should have something but I don't know what yet. |
My preference would be that we have something to replace these with. At the very least, ensure that the code is present within the docs. |
Isn't that what https://github.com/Unity-Technologies/ml-agents/blob/master/docs/Python-API.md and https://github.com/Unity-Technologies/ml-agents/blob/master/gym-unity/README.md are for. If we just move this code around, we will be facing the same problem : we cannot test this code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it all @vincentpierre .
@vincentpierre Okay. But we should make a Jira ticket for setting up a Colab notebook. |
MLA-809 if you want to add to it. |
Proposed change(s)
Deleting the notebooks from the repository.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Jira-418
Types of change(s)
[ ] Bug fix[ ] New feature[ ] Code refactor[ ] Breaking change[ ] Documentation updateChecklist
[ ] Added tests that prove my fix is effective or that my feature worksOther comments