Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the notebooks from the github repository. #3704

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Deleting the notebooks from the repository.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Jira-418

Types of change(s)

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Code refactor
  • [ ] Breaking change
  • [ ] Documentation update
  • Other (feature removal)

Checklist

  • [ ] Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre requested a review from mmattar March 27, 2020 22:52
@vincentpierre vincentpierre self-assigned this Mar 27, 2020
@@ -56,7 +56,6 @@ def run(self):
# Test-only dependencies should go in test_requirements.txt, not here.
"grpcio>=1.11.0",
"h5py>=2.9.0",
"jupyter",
"matplotlib",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove matplotlib too?

@chriselion
Copy link
Contributor

I don't love notebooks in general. But I worry that this doesn't give us any way (that's under source control) to test the LL API or gym interface.

@vincentpierre
Copy link
Contributor Author

By test, you mean testing or letting our users try it out? If it is testing, I think we should have a better way to do it. For letting our users try it out, I think we should have something but I don't know what yet.

@vincentpierre vincentpierre requested a review from awjuliani March 30, 2020 17:09
@awjuliani
Copy link
Contributor

My preference would be that we have something to replace these with. At the very least, ensure that the code is present within the docs.

@vincentpierre
Copy link
Contributor Author

Isn't that what https://github.com/Unity-Technologies/ml-agents/blob/master/docs/Python-API.md and https://github.com/Unity-Technologies/ml-agents/blob/master/gym-unity/README.md are for. If we just move this code around, we will be facing the same problem : we cannot test this code.

Copy link
Contributor

@awjuliani awjuliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it all @vincentpierre .

@awjuliani
Copy link
Contributor

@vincentpierre Okay. But we should make a Jira ticket for setting up a Colab notebook.

@vincentpierre
Copy link
Contributor Author

MLA-809 if you want to add to it.

@vincentpierre vincentpierre merged commit 9121024 into master Mar 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-remove-notebooks branch March 30, 2020 18:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants