Fixing package validation errors. #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2020 17:06
This impacts our API as two public variables have been made private. TODO: fix our CI to catch these automatically, per commit.
chriselion
reviewed
Apr 20, 2020
| @@ -63,7 +63,7 @@ public int height | |||
| } | |||
|
|
|||
| [HideInInspector, SerializeField, FormerlySerializedAs("grayscale")] | |||
| public bool m_Grayscale; | |||
| bool m_Grayscale; | |||
There was a problem hiding this comment.
Thanks, this was supposed to be private (there are public properties below)
|
I asked on slack a few months ago about failing CI for doc xml warnings, but at the time there was nothing. If there are logs in yamato, we can parse them to do our own enforcement (similar to what I did for coverage %) but last I checked I couldn't find them. |
chriselion
approved these changes
Apr 20, 2020
|
@andrewcoh - can you take a look into why the CI tests are failing? My PR doesn't touch any training code. |
|
added 2 commits
April 20, 2020 13:24
commit 3fed09d Author: Ervin T <ervin@unity3d.com> Date: Mon Apr 20 13:21:28 2020 -0700 [bug-fix] Increase buffer size for SAC tests (#3813) commit 99ed28e Author: Ervin T <ervin@unity3d.com> Date: Mon Apr 20 13:06:39 2020 -0700 [refactor] Run Trainers in separate threads (#3690) commit 52b7d2e Author: Chris Elion <chris.elion@unity3d.com> Date: Mon Apr 20 12:20:45 2020 -0700 update upm-ci-utils source (#3811) commit 89e4804 Author: Vincent-Pierre BERGES <vincentpierre@unity3d.com> Date: Mon Apr 20 12:06:59 2020 -0700 Removing done from the llapi doc (#3810)
This reverts commit 72624f0.
delete-merged-branch
bot
deleted the
develop-mm-api-docs-validation-errors
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impacts our API as two public variables have been made private.
TODO: fix our CI to catch these automatically, per commit.
Proposed change(s)
Describe the changes made in this PR.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments